Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #15017: Properly handle and report network errors on page loads. #15285

Merged
merged 1 commit into from Feb 3, 2017
Merged

Issue #15017: Properly handle and report network errors on page loads. #15285

merged 1 commit into from Feb 3, 2017

Conversation

simartin
Copy link
Contributor

@simartin simartin commented Jan 28, 2017 •
edited by larsbergstrom

This patch fixes how network errors are handled during page loads: they would not be reported and cause crashes before, and do not anymore.

  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/servoparser/mod.rs
  • @KiChjang: components/script/dom/servoparser/mod.rs

@highfive
Copy link

warning Warning warning

  • These commits include an empty title element (<title></title>). Consider adding appropriate metadata.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 28, 2017
@pcwalton
Copy link
Contributor

Over to @nox

@pcwalton pcwalton removed their assignment Jan 31, 2017
@nox
Copy link
Contributor

nox commented Feb 3, 2017

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit abc9f78 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Feb 3, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit abc9f78 with merge f0e21d0...

bors-servo pushed a commit that referenced this pull request Feb 3, 2017
Auto merge of #15285 - simartin:issue_15017, r=nox
f0e21d0 
Issue #15017: Properly handle and report network errors on page loads.

<!-- Please describe your changes on the following line: -->
This patch fixes how network errors are handled during page loads: they would not be reported and cause crashes before, and do not anymore.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15017 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15285)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
Approved by: nox
Pushing f0e21d0 to master...

@bors-servo bors-servo merged commit abc9f78 into servo:master Feb 3, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 3, 2017
@simartin simartin deleted the issue_15017 branch February 3, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network errors on page loads don't show any error page
5 participants
@simartin @highfive @pcwalton @nox @bors-servo